Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nanocoap: fix incorrect uses of coap_get_code() #20028

Merged
merged 3 commits into from Nov 2, 2023
Merged

nanocoap: fix incorrect uses of coap_get_code() #20028

merged 3 commits into from Nov 2, 2023

Conversation

benpicco
Copy link
Contributor

Contribution description

These users were not meant to check for the decimal representation of the code.

Testing procedure

Issues/PRs references

split off from #20004

@github-actions github-actions bot added Area: network Area: Networking Area: CoAP Area: Constrained Application Protocol implementations Area: sys Area: System labels Oct 27, 2023
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 27, 2023
@riot-ci
Copy link

riot-ci commented Oct 27, 2023

Murdock results

✔️ PASSED

a8fc0a2 gcoap_fileserver: use coap_get_code_raw()

Success Failures Total Runtime
7953 0 7953 17m:28s

Artifacts

bergzand
bergzand approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@bergzand bergzand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, thanks for the cleanup

@benpicco
Copy link
Contributor Author

benpicco commented Nov 2, 2023

bors merge

@bors bors
Copy link
Contributor

bors bot commented Nov 2, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit c0ae75b into RIOT-OS:master Nov 2, 2023
27 checks passed
@benpicco benpicco deleted the coap_get_code_raw branch November 2, 2023 15:50
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergzand bergzand bergzand approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@chrysn chrysn Awaiting requested review from chrysn

Assignees
No one assigned
Labels
Area: CoAP Area: Constrained Application Protocol implementations Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2024.01
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benpicco @riot-ci @bergzand @MrKevinWeiss