Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nib/_nib-6ln: bail out early if address is no longer assigned [backport 2023.10] #20037

Conversation

MrKevinWeiss
Copy link
Contributor

Backport of #19999

Contribution description

The function checks for netif == NULL several times, but if netif really is NULL we will already crash on _nib_drl_get(NULL, netif->pid);.

Testing procedure

Issues/PRs references

@MrKevinWeiss MrKevinWeiss added the Area: network Area: Networking label Nov 2, 2023
@MrKevinWeiss MrKevinWeiss added Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 2, 2023
@MrKevinWeiss MrKevinWeiss added Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Nov 2, 2023
@riot-ci
Copy link

riot-ci commented Nov 2, 2023

Murdock results

✔️ PASSED

ff27c9d nib/_nib-6ln: don't check twice if address is assigned

Success Failures Total Runtime
7937 0 7937 17m:56s

Artifacts

@benpicco
Copy link
Contributor

benpicco commented Nov 2, 2023

bors merge

Copy link
Contributor

bors bot commented Nov 2, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 2ffdc2c into RIOT-OS:2023.10-branch Nov 2, 2023
31 checks passed
@MrKevinWeiss MrKevinWeiss deleted the backport/2023.10/_handle_rereg_address-NULL branch November 6, 2023 11:52
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.10 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants