CODEOWNERS: clean up #20119
CODEOWNERS: clean up #20119
Conversation
maribu
added
State: WIP
maribu
requested review from
haukepetersen,
cgundogan,
kb2ma,
smlng and
fjmolinas
benpicco
added
the
CI: skip compile test
|
Code owners are always maintainers, right? If yes, then we should probably run a maintainer ping (or use this PR as one) and remove the persons in question from the maintainer list all together. |
No, sometimes also the contributors of a driver / port to a new MCU / foobar have subscribed to code changes as well. The issue is that CODEOWNERS not only is a tool for people to subscribe to changes to parts they care about (which doesn't need cleanup), but also for contributors to get reviewers on boards. IMO the latter use case takes preference over the first. And as stale subscribers appear to be about to review, contributors may get the false impression someone is going to review the PR soon. They may even feel actively being ignored and not just overlooked. And that is why IMO we should keep the file clean of stale subscriptions. |
benpicco
added
the
CI: ready for build
|
Please squash! |
This drops people who have not contributed to RIOT (including, most importantly, reviews) for at least a year. For contributors it is a bit annoying to have a long list of assigned reviewers, but none of them will ever show up to do the review. This is especially true for new contributors who don't know which of the reviewers are active which are ["Karteileichen"][1]. [1]: https://de.wikipedia.org/wiki/Karteileiche
maribu
removed
the
State: WIP
Contribution description
This drops people who have not contributed to RIOT (including, most importantly, reviews) for at least a year.
For contributors it is a bit annoying to have a long list of assigned reviewers, but none of them will ever show up to do the review. This is especially true for new contributors who don't know which of the reviewers are active which are "Karteileichen".
Testing procedure
Let's see if any of the removed persons starts to scream in the next four weeks. If not, I guess it is safe to remove them.
Issues/PRs references
None