drivers/periph_spi: Add spi_transfer_u16_be()
#20312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
added
Type: bug
github-actions
bot
added
Area: tests
This adds a helper function to exchange a 16 bit number that is to be transferred in big endian order on the wire.
This also fixes a bug, as the free coded byte swap code was incorrect.
maribu
force-pushed
the
drivers/periph_common/spi/transfer_u16
branch
from
fa2d171
to
47280b3
Compare
github-actions
bot
removed
Area: tests
maribu
added
the
CI: ready for build
Teufelchen1
approved these changes
Feb 9, 2024
maribu
added
CI: ready for build
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Thx :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This adds
spi_transfer_u16_be()intended to replace the free coded (and buggy) variant in the w5100 driver. This will also be useful for #20301 that needs the same functionality.Testing procedure
The W5100 should work as before on little endian systems, and show now also work on big endian systems. (E.g. running
nativeon a MIPS router with OpenWRT and using the SPI sysfs interface may work.)Issues/PRs references