ipv6/nib: fix router lifetime handling in RIO and fix gnrc_ipv6_nib_ft_add() api #20342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabian18
added
the
CI: ready for build
benpicco
added
the
Type: bug
benpicco
reviewed
Feb 5, 2024
fabian18
force-pushed
the
pr/fix_router_lifetime_and_ft_add_api
branch
from
c67fd2d
to
59e3fa6
Compare
benpicco
reviewed
Feb 6, 2024
benpicco
reviewed
Feb 6, 2024
benpicco
reviewed
Feb 6, 2024
fabian18
force-pushed
the
pr/fix_router_lifetime_and_ft_add_api
branch
from
b380fb0
to
a11a1ea
Compare
benpicco
reviewed
Feb 6, 2024
fabian18
force-pushed
the
pr/fix_router_lifetime_and_ft_add_api
branch
from
a11a1ea
to
fef5c8c
Compare
benpicco
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The lifetime of a prefix comes as a
uint32_tand not as auint16_t.Infinite lifetime is assumed when
0is passed tognrc_ipv6_nib_ft_add().In
_handle_rio()this was not correctly transformed from the option's value to the input ofgnrc_ipv6_nib_ft_add().Testing procedure
The impact is not really big, it should just run fine.
Issues/PRs references