Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnrc_netif: remove deprecated CONFIG_GNRC_NETIF_LORAWAN_NETIF_HDR #20515

Merged
merged 3 commits into from
Mar 28, 2024
Merged

gnrc_netif: remove deprecated CONFIG_GNRC_NETIF_LORAWAN_NETIF_HDR #20515

merged 3 commits into from
Mar 28, 2024

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Mar 27, 2024 •
edited by kfessel

Contribution description

Deprecated since forever and was slated for removal after 2021.10. So let's do it now! As a consequence, I deprecated the now unused (at least in our codebase) GNRC_NETTYPE_LORAWAN and aliased it with GNRC_NETTYPE_UNDEF (and removed the dependency from gnrc_lorawan).

Testing procedure

Everything should still compile as before (in fact, the binary should even look the same, but did not confirm that).

Issues/PRs references

deprecated in #16080

@github-actions github-actions bot added Area: network Area: Networking Area: build system Area: Build system Area: sys Area: System Area: examples Area: Example Applications Area: Kconfig Area: Kconfig integration labels Mar 27, 2024
@miri64 miri64 added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Process: deprecation Integration Process: The PR is deprecating a feature or API CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 27, 2024
Teufelchen1
Teufelchen1 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@Teufelchen1 Teufelchen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trusting Miri... a lot. 😏

@riot-ci
Copy link

riot-ci commented Mar 27, 2024 •
edited

Murdock results

✔️ PASSED

810f1a9 gnrc_lorawan: Remove gnrc_nettype_lorawan dependency

Success Failures Total Runtime
10027 0 10027 12m:10s

Artifacts

@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 27, 2024
@miri64 miri64 force-pushed the gnrc_netif/cleanup/rm-CONFIG_GNRC_NETIF_LORAWAN_NETIF_HDR branch from 1a444ba to 75dc4c8 Compare March 27, 2024 22:23
@miri64
Copy link
Member Author

miri64 commented Mar 27, 2024

Squashed

@miri64 miri64 force-pushed the gnrc_netif/cleanup/rm-CONFIG_GNRC_NETIF_LORAWAN_NETIF_HDR branch from 75dc4c8 to a591ef1 Compare March 27, 2024 22:24
@miri64
Copy link
Member Author

miri64 commented Mar 27, 2024

And rebased.

@miri64 miri64 enabled auto-merge March 27, 2024 22:24
@miri64
gnrc_netif: remove deprecated CONFIG_GNRC_NETIF_LORAWAN_NETIF_HDR
5c75f84
@miri64
gnrc_nettype: deprecate GNRC_NETTYPE_LORAWAN
549f215
@miri64
gnrc_lorawan: Remove gnrc_nettype_lorawan dependency
810f1a9 
With the removal of `CONFIG_GNRC_NETIF_LORAWAN_NETIF_HDR` it does not
use `GNRC_NETTYPE_LORAWAN` anymore, so this module is not required
anymore.
@miri64 miri64 force-pushed the gnrc_netif/cleanup/rm-CONFIG_GNRC_NETIF_LORAWAN_NETIF_HDR branch from a591ef1 to 810f1a9 Compare March 28, 2024 08:19
@miri64
Copy link
Member Author

miri64 commented Mar 28, 2024

And another rebase...

@miri64 miri64 added this pull request to the merge queue Mar 28, 2024
Merged via the queue into RIOT-OS:master with commit 6c46d26 Mar 28, 2024
25 checks passed
@miri64 miri64 deleted the gnrc_netif/cleanup/rm-CONFIG_GNRC_NETIF_LORAWAN_NETIF_HDR branch March 28, 2024 10:55
@kfessel kfessel mentioned this pull request Apr 2, 2024
Closed
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.04 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Teufelchen1 Teufelchen1 Teufelchen1 approved these changes

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: examples Area: Example Applications Area: Kconfig Area: Kconfig integration Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: deprecation Integration Process: The PR is deprecating a feature or API Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2024.04
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miri64 @riot-ci @Teufelchen1 @MrKevinWeiss