tests/drivers/at_unit: fix unit tests on native #20551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derMihai
requested review from
leandrolanzieri,
aabadie and
MichelRottleuthner
as code owners
benpicco
added
CI: ready for build
kfessel
reviewed
Apr 8, 2024
There was a problem hiding this comment.
changes look valid to me @Teufelchen1 might want to have a look
I did not know about this, sorry I missed it.
Uh? I'm pretty sure I tested it on my machine, maybe I confused a branch or something. Thanks for cleaning up after me, looks good! |
Teufelchen1
approved these changes
Apr 8, 2024
Either it doesn't segfault on your machine by chance, or I don't know how to set UART dev 1 on native. I am only aware of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
#20540 breaks two things:
tests/drivers/at/tests-with-config/test_all_configs.shcan not find the AT unit tests anymoreThis PR fixes these issues.
Testing procedure
tests/drivers/at_unit/test_all_configs.shshould finish successfully.Issues/PRs references
#20540