cpu/nrf9160: fix GPIOTE ISR #20560
Merged
cpu/nrf9160: fix GPIOTE ISR #20560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dylan Laduranty <dylan.laduranty@mesotic.com>
github-actions
bot
added
Area: boards
dylad
added
the
CI: ready for build
Signed-off-by: Dylan Laduranty <dylan.laduranty@mesotic.com>
dylad
force-pushed
the
pr/cpu/nrf9160/fix_gpio_isr
branch
from
cae9633
to
f7d0523
Compare
|
Does the isr patch work via this macro? RIOT/cpu/nrf5x_common/include/periph_cpu_common.h Lines 81 to 91 in 9f3786e |
|
Yes, that's it. Since NRF_GPIOTE0_S is defined for nRF9160 as well, I rename the ISR vector to match this macro. |
Teufelchen1
approved these changes
Apr 9, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
On master, GPIO interrupts are broken for nRF9160 MCU. (Dummy handler is called and thus hardfault).
This PR renames the gpiote isr to matches the behavior of nRF53. With this, the GPIO ISR works as expected.
The second commit also enables internal pullups on all nRF9160DK boards buttons as they are required for the hardware to work.
Testing procedure
Flash
tests/buttonsonnrf9160dkboard and play with the onboard buttons.Issues/PRs references
None.