Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples/gcoap: pass through variables to docker #20629

Merged
merged 1 commit into from Apr 30, 2024
Merged

examples/gcoap: pass through variables to docker #20629

merged 1 commit into from Apr 30, 2024

Conversation

maribu
Copy link
Member

@maribu maribu commented Apr 26, 2024 •
edited

Contribution description

Pass through application configuration environment variables to docker, so that one can use e.g. make LWIP_IPV4=1 BUILD_IN_DOCKER=1.

Testing procedure

make LWIP_IPV4=1 BUILD_IN_DOCKER=1 -C examples/gcoap

should now work.

Issues/PRs references

Used to test #18359

@maribu maribu added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 26, 2024
@github-actions github-actions bot added the Area: examples Area: Example Applications label Apr 26, 2024
@riot-ci
Copy link

riot-ci commented Apr 26, 2024 •
edited

Murdock results

✔️ PASSED

0212caf examples/gcoap: pass through variables to docker

Success Failures Total Runtime
72 0 73 01m:24s

Artifacts

@maribu
examples/gcoap: pass through variables to docker
0212caf 
Pass through application configuration environment variables to docker,
so that one can use e.g. `make LWIP_IPV4=1 BUILD_IN_DOCKER=1`.
@maribu maribu changed the title examples/gcoap: pass throw variables to docker examples/gcoap: pass through variables to docker Apr 26, 2024
Teufelchen1
Teufelchen1 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@Teufelchen1 Teufelchen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maribu maribu added this pull request to the merge queue Apr 30, 2024
Merged via the queue into RIOT-OS:master with commit 3783bb1 Apr 30, 2024
26 checks passed
@maribu maribu deleted the examples/gcoap/docker branch April 30, 2024 16:58
@maribu
Copy link
Member Author

maribu commented Apr 30, 2024

Thanks a bunch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Teufelchen1 Teufelchen1 Teufelchen1 approved these changes

Assignees
No one assigned
Labels
Area: examples Area: Example Applications CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maribu @riot-ci @Teufelchen1