doc/doxygen: fix sidenav handling #20631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In https://github.com/RIOT-OS/RIOT/pull/20511/files a quick fix was added to allow resizing the sidenav. But this broke hiding the sidenav on mobile screen widths. This fixes the issue and also increase the default sidenav width a tad.
maribu
added
Type: bug
dylad
approved these changes
Apr 27, 2024
|
Thx :) |
|
Backport provided in #20632 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
In https://github.com/RIOT-OS/RIOT/pull/20511/files a quick fix was added to allow resizing the sidenav. But this broke hiding the sidenav on mobile screen widths. This fixes the issue and also increase the default sidenav width a tad.
Testing procedure
Check the generated doc preview also from a mobile device. It should no longer display the sidenav on small form factors (e.g. phones, or browsers resized to a narrow view) but still allow resizing the sidenav with the mouse on larger form factors.
Issues/PRs references
Fixes regression from #20511