Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build system: rename ethernet feature into netif_ethernet #20694

Merged
merged 1 commit into from
May 27, 2024
Merged

build system: rename ethernet feature into netif_ethernet #20694

merged 1 commit into from
May 27, 2024

Conversation

maribu
Copy link
Member

@maribu maribu commented May 24, 2024

Contribution description

This renames the ethernet feature into netif_ethernet. The goal is to eventually have a number of netif_<type> features that would allow filtering boards by the time of connectivity the have.

Testing procedure

The ethernet feature has not yet been used, so renaming it should not cause any issue. The CI will test this, though.

Issues/PRs references

None

@maribu
build system: rename ethernet feature into netif_ethernet
8ebc102 
The `ethernet` feature has not yet been used, so renaming it should not
cause any issue.

The goal is to eventually have a number of `netif_<type>` features that
would allow filtering boards by the time of connectivity the have.
@github-actions github-actions bot added Platform: native Platform: This PR/issue effects the native platform Area: build system Area: Build system Area: boards Area: Board ports labels May 24, 2024
@maribu maribu added Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed Platform: native Platform: This PR/issue effects the native platform Area: boards Area: Board ports labels May 24, 2024
@maribu maribu mentioned this pull request May 24, 2024
Merged
1 task
@maribu
Copy link
Member Author

maribu commented May 24, 2024

I would be fine if #20695 would get ACKed in merged directly; which depends on and includes this one.

@benpicco
Copy link
Contributor

Looks like you missed some boards that use esp_eth

@riot-ci
Copy link

riot-ci commented May 24, 2024

Murdock results

✔️ PASSED

8ebc102 build system: rename ethernet feature into netif_ethernet

Success Failures Total Runtime
10143 0 10143 15m:02s

Artifacts

@maribu
Copy link
Member Author

maribu commented May 25, 2024

Looks like you missed some boards that use esp_eth

I think that should rather be renamed into periph_eth.

I guess we eventually should have some common place where FEATURES_PROVIDED gets extended based on what is already there. E.g. periph_eth should result in netif_ethernet being added, which in turn should result in netif added. That way boards don't need to explicitly declare the obvious.

mguetschow
mguetschow approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maribu
Copy link
Member Author

maribu commented May 27, 2024

@benpicco Would you be fine with it if I tackle ESP as follow up?

@benpicco
Copy link
Contributor

sure if that makes things any simpler ¯\(ツ)/¯

@maribu maribu added this pull request to the merge queue May 27, 2024
Merged via the queue into RIOT-OS:master with commit 8f4cd50 May 27, 2024
30 checks passed
@maribu maribu deleted the feature/netif_ethernet branch May 27, 2024 13:39
@maribu
Copy link
Member Author

maribu commented May 27, 2024

Thx a bunch :)

@maribu maribu mentioned this pull request May 27, 2024
Merged
@mguetschow mguetschow added this to the Release 2024.07 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguetschow mguetschow mguetschow approved these changes

@benpicco benpicco Awaiting requested review from benpicco benpicco is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

Assignees
No one assigned
Labels
Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care.
Projects
None yet
Milestone
Release 2024.07
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maribu @benpicco @riot-ci @mguetschow