Device Driver for TMP006 Sensor #2148
Conversation
LudwigKnuepfer
added
Area: drivers
| #define TMP006_CCONST_B2 4.63E-9 | ||
| #define TMP006_CCONST_C2 13.4 | ||
| #define TMP006_CCONST_LSB_SIZE 156.25E-9 | ||
|
|
There was a problem hiding this comment.
Why didn't you define the registers in a/the header file?
There was a problem hiding this comment.
I was lazy to create a header file for these 5 registers. The constants can actually be moved to include/tmp006.h.
|
This one looks goog to me. Will test when the hardware arrives :-) |
|
|
||
| *drdy = buf[1] & (uint8_t)(TMP006_CONFIG_DRDY); | ||
|
|
||
| if (!drdy) { |
There was a problem hiding this comment.
cppcheck complains about this line:
drivers/tmp006/tmp006.c:189: warning (nullPointer): Possible null pointer dereference: drdy - otherwise it is redundant to check it against null.
Looks like a false positive to me (you don't check if it is a nullpointer but if the conversion is ready (at least that's what I get from reading the code/comments).
If I'm right you should suppress this warning.
There was a problem hiding this comment.
my error, if (!drdy) -> if (!(*drdy))
|
The application seems to work and runs stable even if I don't know where the offset comes from. Same as for your other drivers, waiting for vtimer bugfix. Also needs squashing like @LudwigOrtmann described in #2121. |
|
@jfischer-phytec-iot I think you did really great work! Acking all your PRs does not seem far. |
OlegHahm
added
the
Community: Hack'n'ACK candidate
|
|
|
@PeterKietzmann, I think we could merge it independent from #2059. |
|
Let's go |
Device Driver for TMP006 Sensor
This PR add support for TI TMP006 Infrared Thermopile Sensor.