Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys: remove uart0 #3164

Merged
merged 11 commits into from
Sep 4, 2015
Merged

sys: remove uart0 #3164

merged 11 commits into from
Sep 4, 2015

Conversation

kaspar030
Copy link
Contributor

uart0 is horrible legacy code. This PR tries to remove all traces of it. (depends on #3161).

I'm trying to create minimal periph/uart implementations based on existing uart0 driver code, and switch to using newlib syscalls uart_stdio for IO handling.

Adapted (checked ones are tested):

missing:
- [ ] redbee-econotag (#3766)

EDIT
Waiting for #3530.

Waiting for #3766.

@kaspar030 kaspar030 added Platform: native Platform: This PR/issue effects the native platform Platform: MSP Platform: This PR/issue effects MSP-based platforms Platform: ARM Platform: This PR/issue effects ARM-based platforms State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Impact: major The PR changes a significant part of the code base. It should be reviewed carefully Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. State: waiting for other PR State: The PR requires another PR to be merged first labels Jun 4, 2015
@jnohlgard
Copy link
Member

Good job! This should making a port for a new platform less confusing for developers new to RIOT.

@haukepetersen
Copy link
Contributor

I was waiting for this for a long time, finally!

@haukepetersen
Copy link
Contributor

Just scanned the code briefly: Couldn't we also remove sys/chardev_thread.c?

@kaspar030
Copy link
Contributor Author

Yes!

@haukepetersen
Copy link
Contributor

yeah!

@haukepetersen haukepetersen mentioned this pull request Jun 14, 2015
Merged
@haukepetersen
Copy link
Contributor

Just made a little change to the shell module, so that we can use putchar and getchar directly for shell_init, which make removing the dependencies to uart0 in the applications quite straight forward and easy... -> #3202

@kaspar030 kaspar030 force-pushed the remove_uart0 branch 2 times, most recently from e11677e to 239445f Compare July 8, 2015 21:43
@kaspar030
Copy link
Contributor Author

@OlegHahm OlegHahm mentioned this pull request Aug 3, 2015
Closed
@PeterKietzmann PeterKietzmann mentioned this pull request Aug 17, 2015
Closed
@OlegHahm OlegHahm removed the State: waiting for other PR State: The PR requires another PR to be merged first label Aug 22, 2015
@OlegHahm
Copy link
Member

As far as I can see this is waiting mostly for the MSP430 refactoring, right?

@OlegHahm OlegHahm mentioned this pull request Aug 22, 2015
Merged
@PeterKietzmann
Copy link
Member

Do I see it correctly that this PR is waiting for #3724 and after that, we can potentially be merged it. Next are #3426 and #3402 ? Or what is missing?

@OlegHahm
Copy link
Member

I think #3724 is only for timers on MSP430.

@PeterKietzmann
Copy link
Member

Ups. I think I meant #3742. And wanted I to awake this PR.

@kaspar030
Copy link
Contributor Author

@kaspar030
Copy link
Contributor Author

Travis happy!

@haukepetersen
Copy link
Contributor

Nice! I can't find anything to complain about anymore - ACK and go!

haukepetersen added a commit that referenced this pull request Sep 4, 2015
@haukepetersen
Merge pull request #3164 from kaspar030/remove_uart0
7701aed 
sys: remove uart0
@haukepetersen haukepetersen merged commit 7701aed into RIOT-OS:master Sep 4, 2015
@haukepetersen haukepetersen deleted the remove_uart0 branch September 4, 2015 16:54
@haukepetersen haukepetersen restored the remove_uart0 branch September 4, 2015 16:54
@kaspar030
Copy link
Contributor Author

🎉 finally! Thanks for reviewing!

@kaspar030 kaspar030 deleted the remove_uart0 branch September 4, 2015 16:55
@haukepetersen
Copy link
Contributor

Thanks for preparing the PR :-) Finally we got rid of uart0, been looking forward to this for a loooong time...

@kaspar030
Copy link
Contributor Author

yep...

Yonezawa-T2 added a commit to Yonezawa-T2/RIOT that referenced this pull request Dec 9, 2015
@Yonezawa-T2
native: add UART driver based on /dev/tty
4009b55 
uart0 functionality is removed by RIOT-OS#3164. This patch implements periph/uart,
rather than deprecated uart0, using /dev/tty.
To use with netdev2_tap simultaneously, this patch adds asynchronus read system
and modifies netdev2_tap to use it.

A TTY device is specified on command line with -c (COM) option, since -t was
used by the old implementation.

This patch also implements empty GPIO driver needed by the xbee driver.
Yonezawa-T2 added a commit to Yonezawa-T2/RIOT that referenced this pull request Dec 9, 2015
@Yonezawa-T2
native: add UART driver based on /dev/tty
9aaadcf 
uart0 functionality is removed by RIOT-OS#3164. This patch implements periph/uart,
rather than deprecated uart0, using /dev/tty.
To use with netdev2_tap simultaneously, this patch adds asynchronus read system
and modifies netdev2_tap to use it.

A TTY device is specified on command line with -c (COM) option, since -t was
used by the old implementation.

This patch also implements empty GPIO driver needed by the xbee driver.
@Yonezawa-T2 Yonezawa-T2 mentioned this pull request Dec 9, 2015
Merged
Yonezawa-T2 added a commit to Yonezawa-T2/RIOT that referenced this pull request Jan 13, 2016
@Yonezawa-T2
native: add UART driver based on /dev/tty
4dc9ed5 
uart0 functionality is removed by RIOT-OS#3164. This patch implements periph/uart,
rather than deprecated uart0, using /dev/tty.
To use with netdev2_tap simultaneously, this patch adds asynchronus read system
and modifies netdev2_tap to use it.

A TTY device is specified on command line with -c (COM) option, since -t was
used by the old implementation.

This patch also implements empty GPIO driver needed by the xbee driver.
Yonezawa-T2 added a commit to Yonezawa-T2/RIOT that referenced this pull request Feb 2, 2016
@Yonezawa-T2
native: add UART driver based on /dev/tty
5b38c87 
uart0 functionality is removed by RIOT-OS#3164. This patch implements periph/uart,
rather than deprecated uart0, using /dev/tty.
To use with netdev2_tap simultaneously, this patch adds asynchronus read system
and modifies netdev2_tap to use it.

A TTY device is specified on command line with -c (COM) option, since -t was
used by the old implementation.

This patch also implements empty GPIO driver needed by the xbee driver.
Yonezawa-T2 added a commit to Yonezawa-T2/RIOT that referenced this pull request Feb 2, 2016
@Yonezawa-T2
native: add UART driver based on /dev/tty
6d2f60d 
uart0 functionality is removed by RIOT-OS#3164. This patch implements periph/uart,
rather than deprecated uart0, using /dev/tty.
To use with netdev2_tap simultaneously, this patch adds asynchronus read system
and modifies netdev2_tap to use it.

A TTY device is specified on command line with -c (COM) option, since -t was
used by the old implementation.

This patch also implements empty GPIO driver needed by the xbee driver.
Yonezawa-T2 added a commit to Yonezawa-T2/RIOT that referenced this pull request Feb 4, 2016
@Yonezawa-T2
native: add UART driver based on /dev/tty
aa80ecc 
uart0 functionality is removed by RIOT-OS#3164. This patch implements periph/uart,
rather than deprecated uart0, using /dev/tty.
To use with netdev2_tap simultaneously, this patch adds asynchronus read system
and modifies netdev2_tap to use it.

A TTY device is specified on command line with -c (COM) option, since -t was
used by the old implementation.

This patch also implements empty GPIO driver needed by the xbee driver.
Yonezawa-T2 added a commit to Yonezawa-T2/RIOT that referenced this pull request Feb 29, 2016
@Yonezawa-T2
native: add UART driver based on /dev/tty
b8be69c 
uart0 functionality is removed by RIOT-OS#3164. This patch implements periph/uart,
rather than deprecated uart0, using /dev/tty.
To use with netdev2_tap simultaneously, this patch adds asynchronus read system
and modifies netdev2_tap to use it.

A TTY device is specified on command line with -c (COM) option, since -t was
used by the old implementation.

This patch also implements empty GPIO driver needed by the xbee driver.
Yonezawa-T2 added a commit to Yonezawa-T2/RIOT that referenced this pull request Mar 23, 2016
@Yonezawa-T2
native: add UART driver based on /dev/tty
a05f255 
uart0 functionality is removed by RIOT-OS#3164. This patch implements periph/uart,
rather than deprecated uart0, using /dev/tty.
To use with netdev2_tap simultaneously, this patch adds asynchronus read system
and modifies netdev2_tap to use it.

A TTY device is specified on command line with -c (COM) option, since -t was
used by the old implementation.

This patch also implements empty GPIO driver needed by the xbee driver.
Yonezawa-T2 added a commit to Yonezawa-T2/RIOT that referenced this pull request Mar 23, 2016
@Yonezawa-T2
native: add UART driver based on /dev/tty
c36bb1f 
uart0 functionality is removed by RIOT-OS#3164. This patch implements periph/uart,
rather than deprecated uart0, using /dev/tty.
To use with netdev2_tap simultaneously, this patch adds asynchronus read system
and modifies netdev2_tap to use it.

A TTY device is specified on command line with -c (COM) option, since -t was
used by the old implementation.

This patch also implements empty GPIO driver needed by the xbee driver.
Yonezawa-T2 added a commit to Yonezawa-T2/RIOT that referenced this pull request Mar 28, 2016
@Yonezawa-T2
native: add UART driver based on /dev/tty
e3a13c1 
uart0 functionality is removed by RIOT-OS#3164. This patch implements periph/uart,
rather than deprecated uart0, using /dev/tty.
To use with netdev2_tap simultaneously, this patch adds asynchronus read system
and modifies netdev2_tap to use it.

A TTY device is specified on command line with -c (COM) option, since -t was
used by the old implementation.

This patch also implements empty GPIO driver needed by the xbee driver.
Yonezawa-T2 added a commit to Yonezawa-T2/RIOT that referenced this pull request Mar 30, 2016
@Yonezawa-T2
native: add UART driver based on /dev/tty
7137b8c 
uart0 functionality is removed by RIOT-OS#3164. This patch implements periph/uart,
rather than deprecated uart0, using /dev/tty.
To use with netdev2_tap simultaneously, this patch adds asynchronus read system
and modifies netdev2_tap to use it.

A TTY device is specified on command line with -c (COM) option, since -t was
used by the old implementation.

This patch also implements empty GPIO driver needed by the xbee driver.
Yonezawa-T2 added a commit to Yonezawa-T2/RIOT that referenced this pull request Mar 31, 2016
@Yonezawa-T2
native: add UART driver based on /dev/tty
43fc7ea 
uart0 functionality is removed by RIOT-OS#3164. This patch implements periph/uart,
rather than deprecated uart0, using /dev/tty.
To use with netdev2_tap simultaneously, this patch adds asynchronus read system
and modifies netdev2_tap to use it.

A TTY device is specified on command line with -c (COM) option, since -t was
used by the old implementation.

This patch also implements empty GPIO driver needed by the xbee driver.
Yonezawa-T2 added a commit to Yonezawa-T2/RIOT that referenced this pull request Mar 31, 2016
@Yonezawa-T2
native: add UART driver based on /dev/tty
79d3389 
uart0 functionality is removed by RIOT-OS#3164. This patch implements periph/uart,
rather than deprecated uart0, using /dev/tty.
To use with netdev2_tap simultaneously, this patch adds asynchronus read system
and modifies netdev2_tap to use it.

A TTY device is specified on command line with -c (COM) option, since -t was
used by the old implementation.

This patch also implements empty GPIO driver needed by the xbee driver.
mayman99 pushed a commit to mayman99/RIOT that referenced this pull request Mar 31, 2016
@Yonezawa-T2 @mayman99
native: add UART driver based on /dev/tty
23983af 
uart0 functionality is removed by RIOT-OS#3164. This patch implements periph/uart,
rather than deprecated uart0, using /dev/tty.
To use with netdev2_tap simultaneously, this patch adds asynchronus read system
and modifies netdev2_tap to use it.

A TTY device is specified on command line with -c (COM) option, since -t was
used by the old implementation.

This patch also implements empty GPIO driver needed by the xbee driver.
lebrush pushed a commit to lebrush/RIOT that referenced this pull request Jun 27, 2016
@Yonezawa-T2
native: add UART driver based on /dev/tty
15d6aa3 
uart0 functionality is removed by RIOT-OS#3164. This patch implements periph/uart,
rather than deprecated uart0, using /dev/tty.
To use with netdev2_tap simultaneously, this patch adds asynchronus read system
and modifies netdev2_tap to use it.

A TTY device is specified on command line with -c (COM) option, since -t was
used by the old implementation.

This patch also implements empty GPIO driver needed by the xbee driver.
jia200x pushed a commit to jia200x/RIOT that referenced this pull request Nov 1, 2016
@Yonezawa-T2 @jia200x
native: add UART driver based on /dev/tty
39507e6 
uart0 functionality is removed by RIOT-OS#3164. This patch implements periph/uart,
rather than deprecated uart0, using /dev/tty.
To use with netdev2_tap simultaneously, this patch adds asynchronus read system
and modifies netdev2_tap to use it.

A TTY device is specified on command line with -c (COM) option, since -t was
used by the old implementation.

This patch also implements empty GPIO driver needed by the xbee driver.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@haukepetersen haukepetersen

Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: major The PR changes a significant part of the code base. It should be reviewed carefully Platform: ARM Platform: This PR/issue effects ARM-based platforms Platform: MSP Platform: This PR/issue effects MSP-based platforms Platform: native Platform: This PR/issue effects the native platform Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2015.09
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kaspar030 @jnohlgard @haukepetersen @OlegHahm @PeterKietzmann @Kijewski