make: delete emptyarchive after test #3302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phiros
added
the
Impact: minor
| @@ -131,7 +131,8 @@ CFLAGS += -DCPU_$(CPUDEF)=\"$(CPU)\" -DRIOT_CPU=CPU_$(CPUDEF) | |||
| CFLAGS += -DMCU_$(MCUDEF)=\"$(MCU)\" -DRIOT_MCU=MCU_$(MCUDEF) | |||
|
|
|||
| # OSX fails to create empty archives. Provide a wrapper to catch that error. | |||
| ifneq (0, $(shell mkdir -p $(BINDIR); $(AR) rc $(BINDIR)empty-archive.a 2> /dev/null; echo $$?)) | |||
| ifneq (0, $(shell mkdir -p $(BINDIR); $(AR) rc $(BINDIR)empty-archive.a 2> /dev/null; \ | |||
| echo $$?; rm -rf $(BINDIR) 2>&1 > /dev/null)) | |||
There was a problem hiding this comment.
This will implicitly clean all artifacts. Better to do rm $(BINDIR)empty-archive.a
phiros
added
the
CI: needs squashing
|
ACK, please squash, go after Travis |
jnohlgard
added
the
CI: ready for build
|
ACK |
phiros
force-pushed
the
make_delete_emptyarchive_archive_after_test
branch
from
0f56921
to
538c992
Compare
phiros
removed
the
CI: needs squashing
phiros
added a commit
that referenced
this pull request
Jul 2, 2015
…_after_test make: delete emptyarchive after test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3280.