Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnrc_ipv6_netif: fixed buffer overrun #4534

Merged
merged 1 commit into from
Dec 22, 2015

Conversation

Yonezawa-T2
Copy link
Contributor

The size of a bitfield should be computed by (bits + 7) / 8. If bits is 8, (bits / 8) + 1 is 2 instead of 1, results in buffer overrun. bitfield.h and bitfield.c use the correct formula.

Splitted from #4447.

@cgundogan cgundogan added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking labels Dec 22, 2015
@cgundogan cgundogan added this to the Release 2015.12 milestone Dec 22, 2015
@cgundogan cgundogan self-assigned this Dec 22, 2015
@cgundogan cgundogan added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 22, 2015
@cgundogan
Copy link
Member

ACK

miri64 added a commit that referenced this pull request Dec 22, 2015
gnrc_ipv6_netif: fixed buffer overrun
@miri64 miri64 merged commit 34974ab into RIOT-OS:master Dec 22, 2015
@miri64
Copy link
Member

miri64 commented Dec 22, 2015

Please provide backport to 2015.12

@cgundogan cgundogan added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Dec 22, 2015
@OlegHahm
Copy link
Member

Nice catch.

@cgundogan cgundogan removed the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Dec 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants