tests: led: use led.h instead of board.h #5213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Type: enhancement
miri64
added
the
State: waiting for other PR
miri64
changed the title
|
NACK -> this changes the behavior of the test application The test is supposed to blink each available LED in a sequence, by removing the (yes, ugly) ifdefs, you introduce a very long delay into the sequence for all boards, that do not have all 8 LEDs defined... |
|
Looking into a different solution now. |
But only at execution time, with a physical board. Not at compile time ;-). But okay, I get it. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent slip-ups like the one in #5212.
Depends on #5212, since the test won't compile for udoo otherwise.