tests: xtimer_msg_receive_timeout: initialize values #5216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Type: bug
miri64
added
the
CI: ready for build
|
Looks valid to me, but was there anything that needed also to be documented, like some timer members have to be initialized before usage or so? |
|
Any problem if I amend it to this PR? |
|
not at all |
|
just making sure we don't forget anything that came up in the discussion in #4372 |
|
Provided the docfix. |
|
i am good with this, @kaspar030: could you please verify! |
| @@ -180,7 +180,9 @@ void xtimer_usleep_until(uint32_t *last_wakeup, uint32_t usecs); | |||
| * The mesage struct specified by msg parameter will not be copied, e.g., it | |||
| * needs to point to valid memory until the message has been delivered. | |||
| * | |||
| * @param[in] timer timer struct to work with | |||
| * @param[in] timer timer struct to work with. | |||
| * Its xtimer_t::target and xtimer_t::long_target | |||
There was a problem hiding this comment.
Auto-generates references to the fields ;-)
|
Or we just always initialize to zero for those functions? |
|
Didn't we came to the conclusion that auto-delete wouldn't work then? |
|
Yes. Let's go with docs for now. ACK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4372