Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/periph: fixed UNDEF values to UINT_MAX #5224

Merged
merged 2 commits into from
Apr 13, 2016
Merged

drivers/periph: fixed UNDEF values to UINT_MAX #5224

merged 2 commits into from
Apr 13, 2016

Conversation

haukepetersen
Copy link
Contributor

fixes #5217

@haukepetersen haukepetersen added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: drivers Area: Device drivers labels Apr 1, 2016
@haukepetersen haukepetersen added this to the Release 2016.04 milestone Apr 1, 2016
@haukepetersen haukepetersen mentioned this pull request Apr 1, 2016
Closed
@haukepetersen haukepetersen added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 1, 2016
@haukepetersen
Copy link
Contributor Author

Seems like Murdock failed unrelated?!

@OlegHahm
Copy link
Member

OlegHahm commented Apr 1, 2016

Nope.

@OlegHahm
Copy link
Member

OlegHahm commented Apr 1, 2016

see haukepetersen#26

@haukepetersen
Copy link
Contributor Author

fixed signedness issues in uart test

@haukepetersen
Copy link
Contributor Author

alright, Murdock is green, anyone up to merge this?

@kYc0o
Copy link
Contributor

kYc0o commented Apr 8, 2016

Code looks ok, should we test on some board?

@haukepetersen
Copy link
Contributor Author

You could do so, but the only place the UNDEF variables are used is in the tests. So as long as they compile without warning (which is the case), everything should be find.

@haukepetersen
Copy link
Contributor Author

@kYc0o ping

@kYc0o
Copy link
Contributor

kYc0o commented Apr 13, 2016

Tested on cc2538dk for uart, and i2c and works well, so ACK and go!

@kYc0o
Copy link
Contributor

kYc0o commented Apr 13, 2016

It also compiles as expected on stm32f4discovery

@kYc0o kYc0o merged commit e6d15f2 into RIOT-OS:master Apr 13, 2016
@haukepetersen haukepetersen deleted the fix_periph_undef branch April 13, 2016 16:00
@miri64
Copy link
Member

miri64 commented Apr 19, 2016

Needs backport.

@miri64 miri64 added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Apr 19, 2016
@miri64 miri64 mentioned this pull request Apr 19, 2016
Merged
@miri64 miri64 removed the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jnohlgard jnohlgard

Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2016.04
Development

Successfully merging this pull request may close these issues.

drivers/periph: default UNDEF constants are negative but type is unsigned
5 participants
@haukepetersen @OlegHahm @kYc0o @miri64 @jnohlgard