Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/lm4f120: fix ADC pin mapping #5264

Merged
merged 1 commit into from
Apr 11, 2016
Merged

cpu/lm4f120: fix ADC pin mapping #5264

merged 1 commit into from
Apr 11, 2016

Conversation

dkm
Copy link
Member

@dkm dkm commented Apr 8, 2016

fix GPIO pin mapping for ADC_0 and use macro to make the mapping less error-prone

@OlegHahm OlegHahm added this to the Release 2016.04 milestone Apr 8, 2016
@OlegHahm OlegHahm added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: drivers Area: Device drivers labels Apr 8, 2016
@haukepetersen
Copy link
Contributor

big dislike -> I think it does not really make it more error prone while introducing an additional layer of macro. NACK from my side (though this might highly subjective). But one of the style goals for RIOT is, to restrict macro usage to only where it's really needed, and in this place I would say this is not the case.

@dkm
Copy link
Member Author

dkm commented Apr 8, 2016

Ok. I can still fix the big struct init, but I think it's harder to match it with the documentation. Should I rework the patch ?

@haukepetersen
Copy link
Contributor

Yes, that would be great!

fix GPIO pin mapping for ADC_0

Signed-off-by: Marc Poulhiès <dkm@kataplop.net>
@dkm
Copy link
Member Author

dkm commented Apr 11, 2016

Done. I've reverted to the previous verbose struct init, but with the mapping corrected.

@haukepetersen haukepetersen added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 11, 2016
@haukepetersen
Copy link
Contributor

ACK once Murdock is green

@OlegHahm OlegHahm merged commit 987f719 into RIOT-OS:master Apr 11, 2016
@dkm
Copy link
Member Author

dkm commented Apr 11, 2016

Thanks !

@dkm dkm deleted the pr/adc branch April 11, 2016 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants