seq: bitwise and instead of mod #5272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgundogan
added
the
Type: enhancement
| @@ -64,7 +64,7 @@ seq16_t seq16_adds(seq16_t s, uint16_t n, uint16_t space) | |||
| return s; | |||
| } | |||
|
|
|||
| return (space == UINT16_MAX) ? (s + n) : (s + n) % (space + 1); | |||
| return (space == UINT16_MAX) ? (s + n) : ((s + n) & space); | |||
There was a problem hiding this comment.
Unrelated, but someone™ should add the assert above for cib ;)
|
ACK and go when Murdock is happy. |
miri64
added
the
CI: ready for build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spaceis expected to be a power of 2 -1.x % yis the same asx & (y-1)ifyis a power of 2.This reduces the unittests by about 200 bytes for the samr21-xpro.