Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAMD21/GPIO driver: Add missing interrupts #5315

Merged
merged 1 commit into from
Apr 19, 2016
Merged

SAMD21/GPIO driver: Add missing interrupts #5315

merged 1 commit into from
Apr 19, 2016

Conversation

biboc
Copy link
Member

@biboc biboc commented Apr 14, 2016

Solves #5312

@biboc biboc added Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: drivers Area: Device drivers labels Apr 14, 2016
@OlegHahm OlegHahm mentioned this pull request Apr 14, 2016
Closed
@haukepetersen
Copy link
Contributor

nice. Can you also include the fixes for pins PA30/31 and PB30/31, then we can close #5316

@biboc
Copy link
Member Author

biboc commented Apr 14, 2016

@haukepetersen, Done

@biboc biboc changed the title SAMD21/GPIO driver: Add interrupt for PA27 SAMD21/GPIO driver: Add missing interrupts Apr 15, 2016
haukepetersen
haukepetersen reviewed Apr 15, 2016
View reviewed changes
cpu/samd21/periph/gpio.c
{ 0, -1, 2, 3, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1,
0, 1, -1, -1, -1, -1, 6, 7, -1, -1, -1, 15, 8, -1, 10, 11},
0, 1, -1, -1, -1, -1, 6, 7, -1, -1, -1, 0, 8, -1, -1, -1},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the mapping for PB27 should be -1, right?

@haukepetersen
Copy link
Contributor

ACK once PB27 is fixed.

@haukepetersen haukepetersen added this to the Release 2016.04 milestone Apr 15, 2016
@haukepetersen haukepetersen added Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 15, 2016
@kYc0o
Copy link
Contributor

kYc0o commented Apr 19, 2016

@bapclenet can you address the last comment so it gets merged ASAP? Otherwise we'll need to postpone it (a pity since it's almost done)

@haukepetersen
Copy link
Contributor

I merge this now and provide a quick-fix right after

@haukepetersen haukepetersen merged commit fbb144f into RIOT-OS:master Apr 19, 2016
@haukepetersen haukepetersen mentioned this pull request Apr 19, 2016
Merged
@haukepetersen
Copy link
Contributor

-> see #5353

@haukepetersen haukepetersen mentioned this pull request Apr 20, 2016
Closed
@miri64 miri64 mentioned this pull request Apr 20, 2016
Merged
@miri64 miri64 removed Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 20, 2016
@miri64
Copy link
Member

miri64 commented Apr 20, 2016

PR was hogging murdock... removed label because of that.

@biboc
Copy link
Member Author

biboc commented Apr 24, 2016

@haukepetersen, wasn't here last week, thank you for merging it!

@haukepetersen
Copy link
Contributor

you're welcome :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kaspar030 kaspar030

Labels
Area: drivers Area: Device drivers Platform: ARM Platform: This PR/issue effects ARM-based platforms
Projects
None yet
Milestone
Release 2016.04
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@biboc @haukepetersen @kYc0o @miri64 @kaspar030