Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnrc_netdev: add deprecation note #5352

Merged
merged 1 commit into from
Apr 20, 2016

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Apr 19, 2016

Fixes #4975.

@miri64 miri64 added Area: network Area: Networking Area: doc Area: Documentation Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch labels Apr 19, 2016
@miri64 miri64 added this to the Release 2016.04 milestone Apr 19, 2016
@kaspar030
Copy link
Contributor

Hm, OK, maybe just something like "This interface is deprecated. Use netdev2 for new drivers."? Anyhow, any note is fine, so change if you feel like, ACK otherwise. :)

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 19, 2016
@miri64
Copy link
Member Author

miri64 commented Apr 19, 2016

I feel like some explanation of why you should do something is always helpful ;-)

@kaspar030
Copy link
Contributor

Well, this way someone might come to the conclusion that he only wants to support gnrc and then get sad when he realizes we won't merge his code. :)

@miri64
Copy link
Member Author

miri64 commented Apr 19, 2016

Deprecated is deprecated, so if someone uses it regardless, because they did not read the whole note, its their own fault ;-)

@OlegHahm
Copy link
Member

I second @kaspar030. Maybe you can just reverse the order of the sentences, i.e. first say that netdev2 is the current way to go, then explain what was the shortcoming of the old interface. (I'm not so sure that the explanation is needed at all, but I don't have strong feelings here.)

@miri64
Copy link
Member Author

miri64 commented Apr 20, 2016

Done.

@miri64 miri64 added CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable and removed Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch labels Apr 20, 2016
@haukepetersen
Copy link
Contributor

ACK when squashed

@miri64 miri64 force-pushed the gnrc_netdev/doc/add-deprecation branch from 20cf9ed to 6dbb515 Compare April 20, 2016 12:01
@miri64
Copy link
Member Author

miri64 commented Apr 20, 2016

Squashed

@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 20, 2016
@miri64 miri64 merged commit 452fc91 into RIOT-OS:master Apr 20, 2016
@miri64 miri64 deleted the gnrc_netdev/doc/add-deprecation branch April 20, 2016 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: doc Area: Documentation Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants