Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lwip: initialize link-local address correctly #5718

Merged
merged 1 commit into from Aug 9, 2016

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Aug 2, 2016

lwIP does some weird byte-swapping in netif_create_ip6_linklocal_address()
with non-ethernet-addresses, so I rather initialize it like in GNRC, so it is
compatible to both GNRC and emb6.

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking Area: pkg Area: External package ports labels Aug 2, 2016
@miri64 miri64 added this to the Release 2016.10 milestone Aug 2, 2016
@miri64 miri64 changed the title lwip: inialize link-local address correctly lwip: initialize link-local address correctly Aug 2, 2016
lwIP does some weird byte-swapping in netif_create_ip6_linklocal_address()
with non-ethernet-addresses, so I rather initialize it like in GNRC, so it is
compatible to both GNRC and emb6.
@miri64
Copy link
Member Author

miri64 commented Aug 2, 2016

Marked for 2016.10, since we can't fix the IEEE 802.15.4 header parsing issue for this release anyway, so Interop between the other stacks isn't possible anyway.

@kYc0o
Copy link
Contributor

kYc0o commented Aug 2, 2016

Ok let's try for the next release.

@miri64
Copy link
Member Author

miri64 commented Aug 2, 2016

We shouldn't just try, but do ;-) but the interop is lwIP's business ;-)

@miri64 miri64 added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Aug 4, 2016
@PeterKietzmann
Copy link
Member

I can confirm that with this PR, local address and EUI-64 in lwip correlate like in RIOT. However, I am still not able to transmit UDP packets between two nodes, one with tests/lwip and one with examples/gnrc_networking.

so Interop between the other stacks isn't possible anyway

@miri64 do you say it is known that both stacks are currently not interoperable?

@miri64
Copy link
Member Author

miri64 commented Aug 9, 2016

Yes, but that's on lwIP's side. They don't parse the IEEE 802.15.4 header correctly (they don't check the source PAN elision flag, but skip it anyway).

@PeterKietzmann PeterKietzmann added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 9, 2016
@PeterKietzmann
Copy link
Member

Well, that's a pity but not part of this PR. ACK and go. Will you provide a backport to the latest release branch?

@PeterKietzmann PeterKietzmann merged commit 178930e into RIOT-OS:master Aug 9, 2016
@miri64
Copy link
Member Author

miri64 commented Aug 9, 2016

Yapp: #5741

@miri64 miri64 removed the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants