cc2538: disable l2 ack recv irq #5869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smlng
added
Area: network
|
Btw. see datasheet page 716 |
|
In the long run we should adjust the recv() function to handle ACKs proprly in order to allow some sort of monitor mode (for wireshark sniffing etc.). But I am fine with disabling the ACK reception interrupt for now. Will test later at @ Hack'N'ACK |
cgundogan
added
the
CI: ready for build
PeterKietzmann
approved these changes
Sep 27, 2016
There was a problem hiding this comment.
Checked the manual and tested if it fixes the bug described in #5840 (crash after receiving an external ACK frame). Additionally tested ICMPv6 and UDP traffic between a remote-reva and a samr21-xpro. Everything with success. ACK
PeterKietzmann
added
the
Type: bug
|
That was fast! I was about to test :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables a filtering option that otherwise raises an recv IRQ when any layer 2 ACK is received, even if it does not match any pending ACK of the node iftself. This leads to a kernel panic caused by a failed assertion, as described in #5840 and further discussed in #5786.