Sock: fixed insconsistencies in the doc #6169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuelsearch
added
Type: bug
miri64
requested changes
Nov 29, 2016
| @@ -26,6 +26,8 @@ | |||
| * #include <stdio.h> | |||
| * | |||
| * #include "net/sock/udp.h" | |||
| * #include "net/af.h" | |||
| * #include "net/sock/ip.h" | |||
There was a problem hiding this comment.
OK so I will remove the mention they are needed in subsequent parts of the doc.
miri64
reviewed
Nov 29, 2016
| * `buf` to store the data received by the server: | ||
| * | ||
| * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ {.c} | ||
| * #include "net/af.h" | ||
| * #include "net/sock/ip.h" |
There was a problem hiding this comment.
I think this was actually supposed to be net/sock/udp.h. The sentence above needs some work then.
emmanuelsearch
force-pushed
the
sock-doc
branch
from
e492b25
to
a0ccc31
Compare
fixed insconsistency concerning headers needed fixed insconsistency concerning headers needed fixed insconsistency concerning headers needed
emmanuelsearch
force-pushed
the
sock-doc
branch
from
a0ccc31
to
cab947b
Compare
|
Please squash |
|
Sorry, did not see you did that already |
miri64
approved these changes
Nov 29, 2016
miri64
added
the
CI: ready for build
|
fixed and squashed |
|
No need to wait for Murdock on this Doc fix |
miri64
added
Process: needs backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.