updated makefiles & a handler for the heap state shell command #64
Conversation
| extern void heap_stats(void); | ||
|
|
||
| void _heap_handler(char* unnused){ | ||
| heap_stats(); |
There was a problem hiding this comment.
you are just adding one line of production code. please remove all "windows compat lines" and create one (1) commit and a new pull request.
There was a problem hiding this comment.
Ø you are just adding one line of production code
one “Line Of Production code” follows the same scheme as in “sc_ps.c”, “sc_id.c.”, etc.
In sys/shell/commands/sc_heap.c:
+extern void heap_stats(void);
+void _heap_handler(char* unnused){
heap_stats();
you are just adding one line of production code. please remove all "windows compat lines" and create one (1) commit and a new pull request.
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/64/files#r5195888.
There was a problem hiding this comment.
one “Line Of Production code” follows the same scheme as in “sc_ps.c”, “sc_id.c.”, etc.
In sys/shell/commands/sc_heap.c:
+extern void heap_stats(void);
+void _heap_handler(char* unnused){
heap_stats();
you are just adding one line of production code. please remove all "windows compat lines" and create one (1) commit and a new pull request.
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/64/files#r5195888.
There was a problem hiding this comment.
On 07/16/2013 11:35 AM, Zakaria Kasmi wrote:
In sys/shell/commands/sc_heap.c:
+extern void heap_stats(void);
+
+void _heap_handler(char* unnused){
- heap_stats();
one “Line Of Production code” follows the same scheme as in “sc_ps.c”, “sc_id.c.”, etc.
This might be correct, but the commits introducing “sc_ps.c”,
“sc_id.c.”, etc. didn't introduce "Makefile fixes".
If we pull your one-liner together with the (unrelated) makefile updates, there'll
be a "merge commit". Now imagine your one line has a problem somewhere
else, and we revert the merge commit. That would also unmerge your
Makefile "fixes". (Makefile updates adding your .c file is totally OK)
Christian proposed to seperate the makefile fixes from your added
functionality.
|
what is meant by ""windows compat lines"? i find no lines !!! |
|
On 07/16/2013 12:14 PM, Zakaria Kasmi wrote:
|
|
It is inconvenient for the Windows-user each time to change On 07/16/2013 12:14 PM, Zakaria Kasmi wrote:
— |
|
On 07/16/2013 01:23 PM, Zakaria Kasmi wrote:
|
By including an ffi.rs file in the crate directory. Fixes RIOT-OS#64
Two small bug fixes Closes RIOT-OS#52 and RIOT-OS#64 See merge request !31
Example/ moisture sensor
Updated makefiles allowing a shell working with spaces in paths. And a handler for the heap state shell command.