Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packer: import openocd udev rules #7126

Merged
merged 2 commits into from Jun 2, 2017

Conversation

cgundogan
Copy link
Member

@cgundogan cgundogan commented Jun 2, 2017

Import all udev rules from openocd.
Source is from [1].

Thanks @haukepetersen for the pointer!

The box still needs to be built and uploaded to hashicorp. @smlng do you want to try that? This is a good opportunity to see if not just me can build+upload our box.

[1] https://github.com/gnuarmeclipse/openocd/blob/master/contrib/60-openocd.rules

EDIT: additionally add some custom rules

@cgundogan cgundogan added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: tools Area: Supplementary tools labels Jun 2, 2017
@cgundogan cgundogan requested a review from smlng June 2, 2017 08:48
@miri64
Copy link
Member

miri64 commented Jun 2, 2017

From my edits to this file: can you add the following lines, too?

# cp210x UART
ATTRS{idVendor}=="10c4", ATTRS{idProduct}=="ea60", MODE="664", GROUP="plugdev"

# Arduino Due
ATTRS{idVendor}=="2341", ATTRS{idProduct}=="003d", MODE="664", GROUP="plugdev"

@miri64
Copy link
Member

miri64 commented Jun 2, 2017

(you may add the uaccess tag, too)

@cgundogan
Copy link
Member Author

@miri64 addressed your comment. I did this in a separate commit to keep the original openocd file intact.

@cgundogan
Copy link
Member Author

or better .. I will do it in another file

@cgundogan
Copy link
Member Author

@miri64 I added them in a separate file.

@miri64
Copy link
Member

miri64 commented Jun 2, 2017

👍

@smlng
Copy link
Member

smlng commented Jun 2, 2017

This is a good opportunity to see if not just me can build+upload our box.

or to offload work to others 😉

Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on macOS, ACK!

@smlng smlng added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 2, 2017
@smlng
Copy link
Member

smlng commented Jun 2, 2017

still prefer to have this in a separate repo in the (near) future

@smlng smlng merged commit 3cdb92a into RIOT-OS:master Jun 2, 2017
@cgundogan
Copy link
Member Author

did you built and uploaded the box @smlng ?

@cgundogan cgundogan deleted the pr/packer_udev_rules branch June 2, 2017 15:12
@smlng
Copy link
Member

smlng commented Jun 2, 2017

build: yes, upload: not yet, will do now 😉

@smlng
Copy link
Member

smlng commented Jun 2, 2017

done, for testing I made it a new version -> 0.0.2

@cgundogan
Copy link
Member Author

hm weird.. the box you created is ~80mb more in size than the previous one

@smlng
Copy link
Member

smlng commented Jun 3, 2017

yeah saw that, too - maybe 'cause I built it on macOS and/or different VirtualBox Version?

@aabadie aabadie modified the milestone: Release 2017.07 Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants