Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

periph/rtc: add support for stm32l4 #7420

Merged
merged 2 commits into from
Aug 21, 2017
Merged

periph/rtc: add support for stm32l4 #7420

merged 2 commits into from
Aug 21, 2017

Conversation

MichelRottleuthner
Copy link
Contributor

As the title says, this adds rtc support for stm32l4. Currently this was only tested on nucleo-l476.
Can someone test this on other stm32l4-based boards?

haukepetersen
haukepetersen approved these changes Jul 27, 2017
View reviewed changes
Copy link
Contributor

@haukepetersen haukepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested ACK.

Changes look valid to me, although I would of course rather like a cleaner approach like done in #6504, but this would require all STMs to adapt to the stmclk interface (#7123)

@smlng smlng added Area: drivers Area: Device drivers Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: timers Area: timer subsystems labels Jul 28, 2017
@MichelRottleuthner
Copy link
Contributor Author

@haukepetersen I assume your ACK still holds?

@MichelRottleuthner MichelRottleuthner mentioned this pull request Aug 7, 2017
Merged
@MichelRottleuthner
Copy link
Contributor Author

ping @haukepetersen

@aabadie aabadie added this to the Release 2017.10 milestone Aug 14, 2017
@aabadie aabadie self-assigned this Aug 15, 2017
@haukepetersen
Copy link
Contributor

yes. All green -> go.

@haukepetersen haukepetersen merged commit 768459d into RIOT-OS:master Aug 21, 2017
@haukepetersen
Copy link
Contributor

@MichelRottleuthner would you be willing to put some efforts into #7123?

@MichelRottleuthner
Copy link
Contributor Author

@haukepetersen you mean like #7469? But with #7477 it would make sence to integrate the changes there.

@MichelRottleuthner MichelRottleuthner deleted the rtc_stm32l4 branch August 21, 2017 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haukepetersen haukepetersen haukepetersen approved these changes

Assignees

@aabadie aabadie

Labels
Area: drivers Area: Device drivers Area: timers Area: timer subsystems CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2017.10
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MichelRottleuthner @haukepetersen @aabadie @smlng