New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu/sam0-common: rename mkr ldscript to more a generic name #7646
Conversation
Small nitpick :-) From my point of view, it's not generic linker script, it's linker script which targets SAMD21G18A MCU with Arduino bootloader pre-flashed, so probably the more appropriate linker filename would be |
Good point, I buy it. Thanks! |
using the suffix Edit: To be constructive: I suggest adding a README.md file to the ldscripts directory to explain which script should be used for what. |
4b2cdd0
to
028e12c
Compare
Added and comments welcome. |
14fb08c
to
0aef67d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, but I don't have the hardware to test it.
that starts after a preflashed Arduino bootloader. The firmware is copied to | ||
the flash memory using [Bossa](https://github.com/shumatech/BOSSA). | ||
This is the kind of configuration used with Arduino MKR and Adafruit Feather | ||
M0 boards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing newline at end of file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed and directly squashed.
Thanks for adding the README |
0aef67d
to
eb0c537
Compare
eb0c537
to
282f691
Compare
It would be nice to merge this one, it's required for #7510. |
I did not test on actual hardware, but this is only a rename and should be working on real hardware if the build succeeded and it worked before. |
This is because this ldscript can be used with any samd21 with an Arduino compatible bootloader preflashed. The idea is just to use a more generic name for the ldscript file.
This is the case for all Arduino MKR boards, Adafruit Feather boards (see #7510) and others.
This PR should address the question of #7645.