tests: sock: remove timing tests from pexpect script #7816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Process: needs backport
|
all green -> go. |
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Oct 24, 2017
As with RIOT-OS#7816: testing timings over the UART doesn't make much sense. This PR removes those timer testing in `pexpect` for `tests/xtimer_usleep` and simplifies and cleans-up a lot of code overall (converting counting while-loops to for-loops, syncing iterations of the test etc.)
|
Backport in #7817 |
miri64
removed
the
Process: needs backport
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Oct 24, 2017
As with RIOT-OS#7816: testing timings over the UART doesn't make much sense. This PR removes those timer testing in `pexpect` for `tests/xtimer_usleep` and simplifies and cleans-up a lot of code overall (converting counting while-loops to for-loops, syncing iterations of the test etc.)
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Oct 24, 2017
As with RIOT-OS#7816: testing timings over the UART doesn't make much sense. This PR removes those timer testing in `pexpect` for `tests/xtimer_usleep` and simplifies and cleans-up a lot of code overall (converting counting while-loops to for-loops, syncing iterations of the test etc.)
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Oct 24, 2017
As with RIOT-OS#7816: testing timings over the UART doesn't make much sense. This PR removes those timer testing in `pexpect` for `tests/xtimer_usleep` and simplifies and cleans-up a lot of code overall (converting counting while-loops to for-loops, syncing iterations of the test etc.)
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Oct 24, 2017
As with RIOT-OS#7816: testing timings over the UART doesn't make much sense. This PR removes those timer testing in `pexpect` for `tests/xtimer_usleep` and simplifies and cleans-up a lot of code overall (converting counting while-loops to for-loops, syncing iterations of the test etc.)
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Oct 25, 2017
As with RIOT-OS#7816: testing timings over the UART doesn't make much sense. This PR removes those timer testing in `pexpect` for `tests/xtimer_usleep` and simplifies and cleans-up a lot of code overall (converting counting while-loops to for-loops, syncing iterations of the test etc.)
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Oct 25, 2017
As with RIOT-OS#7816: testing timings over the UART doesn't make much sense. This PR removes those timer testing in `pexpect` for `tests/xtimer_usleep` and simplifies and cleans-up a lot of code overall (converting counting while-loops to for-loops, syncing iterations of the test etc.)
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Oct 25, 2017
As with RIOT-OS#7816: testing timings over the UART doesn't make much sense. This PR removes those timer testing in `pexpect` for `tests/xtimer_usleep` and simplifies and cleans-up a lot of code overall (converting counting while-loops to for-loops, syncing iterations of the test etc.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the idea is nice UART does not provide the timing constraints to do the kind of timing tests we do for the
socktests at the moment. Because of that they are removed in this PR.