Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fix python E127 'continuation line over/under-indented for visual indent' #8196

Merged
merged 1 commit into from Dec 4, 2017
Merged

tests: fix python E127 'continuation line over/under-indented for visual indent' #8196

merged 1 commit into from Dec 4, 2017

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Dec 3, 2017

Another one that partially addressed #8141.

@aabadie aabadie mentioned this pull request Dec 3, 2017
Closed
12 tasks
@aabadie aabadie added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: tests Area: tests and testing framework labels Dec 3, 2017
miri64
miri64 reviewed Dec 4, 2017
View reviewed changes
tests/gnrc_netif/tests/01-run.py
@@ -20,49 +20,39 @@ def testfunc(child):
# output cross-checked hex data with WireShark -> "Import from Hex Dump..."
# test_netapi_send__raw_unicast_ethernet_packet
child.expect("Sending data from Ethernet device:")
child.expect("00000000 3E E6 B5 0F 19 23 3E E6 B5 22 FD 0A " +
"FF FF 41 42")
child.expect("00000000 3E E6 B5 0F 19 23 3E E6 B5 22 FD 0A FF FF 41 42")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this also clash with another PEP8 rule?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes by default we use 80 max line length but since it's not very handy with tests scripts, the convention in #8141 proposes to increase this to 120.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.

miri64
miri64 approved these changes Dec 4, 2017
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@miri64 miri64 merged commit 73d1cca into RIOT-OS:master Dec 4, 2017
@aabadie aabadie added this to the Release 2018.01 milestone Jan 18, 2018
@aabadie aabadie deleted the pr/tests/python_E12x branch February 26, 2018 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2018.01
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aabadie @miri64