toolchains: print git version #8290
Conversation
smlng
added
Type: enhancement
| @@ -91,4 +91,5 @@ for p in avr; do | |||
| done | |||
| printf "%20s: %s\n" "cppcheck" "$(cppcheck_version)" | |||
| printf "%20s: %s\n" "coccinelle" "$(spatch_version)" | |||
| printf "%20s: %s\n" "git" "$(git --version)" | |||
There was a problem hiding this comment.
I guess we can assume git is always available? If it isn't, would "$(git --version || echo "missing/error")" yield tousable output?
There was a problem hiding this comment.
thought about that, too first - but if there is no git you can't clone/checkout RIOT and never call this script right?
There was a problem hiding this comment.
Theoretically speaking a user would be able to download a zip file from github and never touch git right?
There was a problem hiding this comment.
I amended a proper version check as for other tools. Though, I doubt someone would download RIOT as a ZIP and would then call a script that is supposed to be used by CI (only).
smlng
force-pushed
the
ci/toolchain/print_git_version
branch
from
de6e338
to
e18aa35
Compare
|
@kaspar030 and @bergzand: your comments are addressed, do you ACK? |
Contribution description
Minor enhancement to print the GIT version used by the CI, recently found that pkg libcoap patching fails with newer GIT versions, so might be good to know which is used by CI and which one has on their system.
Issues/PRs references
See also #8289