Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefiles/modules.inc.mk: remove setting deprecated FEATURE_PERIPH_ macros #8291

Closed
wants to merge 1 commit into from

Conversation

cladmi
Copy link
Contributor

@cladmi cladmi commented Dec 19, 2017

This PR removes setting the FEATURES_PERIPH_ macros as they are completely unused and said deprecated.

There will be no reference after #8227
Was cleaned up also by: #8226

TODO: Modify the commit message to add reference to when it was deprecated.

…E_PERIPH_ macros

`#ifdef FEATURE_PERIPH_NAME` usage should now be replaced by
`#ifdef MODULE_PERIPH_NAME`.

TODO ADD REFERENCE TO DEPRECATION
@cladmi cladmi added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: build system Area: Build system State: waiting for other PR State: The PR requires another PR to be merged first labels Dec 19, 2017
@cladmi cladmi closed this Dec 19, 2017
@cladmi cladmi deleted the pr/deprecated/feature_macros branch December 19, 2017 16:25
@cladmi
Copy link
Contributor Author

cladmi commented Dec 19, 2017

Sorry pushed to the wrong repository (I am allowed to push on RIOT repo ?), will recreate on my fork.

@cladmi cladmi removed the request for review from jnohlgard December 19, 2017 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: build system Area: Build system State: waiting for other PR State: The PR requires another PR to be merged first Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant