Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/nz32-sc151: fix ingroup directive in periph_conf #8710

Merged
merged 1 commit into from Mar 2, 2018

Conversation

jia200x
Copy link
Member

@jia200x jia200x commented Mar 1, 2018

Contribution description

This PR fixes wrong @ingroup directive in NZ32-SC151's periph_conf.h. With this change, doxygen now adds a reference to this periph_conf.h file.

Issues/PRs references

None.

@jia200x jia200x added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: doc Area: Documentation Area: boards Area: Board ports labels Mar 1, 2018
@jia200x jia200x requested a review from aabadie March 1, 2018 10:47
@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 1, 2018
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

(the commit message should be boards/nz32-sc151: fix ingroup directive in periph_conf, but that's ok)

@jia200x
Copy link
Member Author

jia200x commented Mar 1, 2018

(the commit message should be boards/nz32-sc151: fix ingroup directive in periph_conf, but that's ok)

Ah, perfect. I will change it. Thank you!

@jia200x jia200x changed the title doc/nz32-sc151: fix ingroup directive in periph_conf boards/nz32-sc151: fix ingroup directive in periph_conf Mar 2, 2018
@jia200x
Copy link
Member Author

jia200x commented Mar 2, 2018

@aabadie fixed!

@aabadie
Copy link
Contributor

aabadie commented Mar 2, 2018

The commit comment is still the same @jia200x !

@aabadie
Copy link
Contributor

aabadie commented Mar 2, 2018

Just use git commit --amend and force push

@jia200x
Copy link
Member Author

jia200x commented Mar 2, 2018

bah, seems I forgot to push

@jia200x
Copy link
Member Author

jia200x commented Mar 2, 2018

done

@aabadie aabadie merged commit c71bed6 into RIOT-OS:master Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants