Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/semtech-loramac: small enhancements in package Makefile #8740

Merged
merged 1 commit into from Mar 7, 2018
Merged

pkg/semtech-loramac: small enhancements in package Makefile #8740

merged 1 commit into from Mar 7, 2018

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Mar 5, 2018

Contribution description

This PR adds small enhancements to the Semtech Loramac package Makefile:

  • use https protocol in source url instead of git:// : this morning during a practical course, some people had a problem with a staled download. Using https fixed the problem. Since it's used in most of the other packages, I think this is safe
  • hide cp commands used with package Makefiles : this is a purely cosmetic change

Issues/PRs references

None

@aabadie
pkg/semtech-loramac: small enhancement in Makefile
d6cf5a1 
- use https protocol in source url
- hide cp commands used for package Makefiles
@aabadie aabadie added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: build system Area: Build system Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 5, 2018
miri64
miri64 approved these changes Mar 7, 2018
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@miri64 miri64 merged commit 89127d7 into RIOT-OS:master Mar 7, 2018
@aabadie aabadie deleted the pr/pkg/semtech-loramac-make-fix branch June 8, 2018 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees

@jia200x jia200x

Labels
Area: build system Area: Build system Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aabadie @miri64 @jia200x