drivers/cc110x: Fix SPI communication on STM32F4 boards #9230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I prefer this solution over variant 2, it's less intrusive. |
aabadie
reviewed
May 29, 2018
drivers/cc110x/cc110x-spi.c
Outdated
| @@ -53,6 +53,10 @@ void cc110x_cs(cc110x_t *dev) | |||
| /* Switch MISO/GDO1 to GPIO input mode */ | |||
| #ifndef GPIO_READS_SPI_PINS | |||
| gpio_init(dev->params.gdo1, GPIO_IN); | |||
| #endif | |||
| #ifdef CC110X_PARAM_GDO1_AF | |||
| /* Reconfigure MISO/GDO1 to be used as regulare GPIO */ | |||
The GDO1/MISO needs to be used as GPIO input in `cc110x_cs()`. On some boards, a call to `gpio_init_af()` is required. This commit allows to `#define` `CC110X_PARAM_GDO1_AF` to enable both the call to `gpio_init_af()` and set the value to pass to `gpio_int_af()`. If `CC110X_PARAM_GDO1_AF` is not defined in `board.h`, the behaviour remains unchanged.
This fixes communication issues with the CC1101 transceiver, as the board can now determine reliably when the transceiver is ready.
maribu
force-pushed
the
cc110x-fix-variant1
branch
from
e2335ad
to
3070193
Compare
This is true. But on the other hand a user of |
|
In any case it seems to be good idea to add a warning to the documentation of |
|
This does not solve the problem :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the first variant of how to fix issue #9225. Please follow the discussion in the issue before merging, as there is an alternative way to fix the issue.