-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: documentation: updated, improved, and completed doxygen comments #983
Conversation
For |
* @def BS_COND | ||
* @brief Conditional setting of a bitmask | ||
* | ||
* @param[in] condition The condition to be checked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the condition is also bitwise, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I'm not 100% sure, but probably yes. I would still vote for removing these two macros.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for deleting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I don't understand is the -
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got the feeling it maybe should be ~
, because two-compliment does not make any sense here, while one-compliment makes at least a little bit sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another reason to delete the macro. Maybe be made sense once, but since then we forgot the meaning ...
Replace “task“ with “thread“ in sched.h:42 and sched.h:66? |
Thanks for the comments. Updated. |
@@ -1,5 +1,5 @@ | |||
/* | |||
* Copyright (C) 2013 Freie Universität Berlin | |||
* Copyright (C) 2014 Freie Universität Berlin | |||
* | |||
* This file subject to the terms and conditions of the GNU Lesser General |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file is subject
sched.h |
Updated. |
ACK. |
ACK, go when squashed |
Squashed. |
core: documentation: updated, improved, and completed doxygen comments
Closes #948