Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/color/color.c: Fix a typo #9939

Merged
merged 1 commit into from Sep 15, 2018
Merged

sys/color/color.c: Fix a typo #9939

merged 1 commit into from Sep 15, 2018

Conversation

pekkanikander
Copy link
Contributor

Contribution description

Fixes a trivial typo in sys/color/color.c I found this by chance while seeing how to convert the HSV colour handling to fixed point.

Testing procedure

I am not aware of any test case for the bug, nor did I write one. Hence, fixing this should not change the test results.

Issues/PRs references

jnohlgard
jnohlgard approved these changes Sep 15, 2018
View reviewed changes
Copy link
Member

@jnohlgard jnohlgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested ACK

@jnohlgard jnohlgard added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 15, 2018
@jnohlgard jnohlgard added this to the Release 2018.10 milestone Sep 15, 2018
@miri64 miri64 mentioned this pull request Sep 15, 2018
Merged
miri64
miri64 approved these changes Sep 15, 2018
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. The change is sensible (though not visible when rendered) and the previous state was clearly a typo. Tested with #9940.

@miri64 miri64 merged commit 090a762 into RIOT-OS:master Sep 15, 2018
@kfessel kfessel mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnohlgard jnohlgard jnohlgard approved these changes

@miri64 miri64 miri64 approved these changes

Assignees
No one assigned
Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2018.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pekkanikander @jnohlgard @miri64