Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed not scrollable currency menu #138

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Fixed not scrollable currency menu #138

merged 1 commit into from
Jan 23, 2024

Conversation

jackrua
Copy link
Contributor

@jackrua jackrua commented Jan 23, 2024

See issue #137

  • Fixed typo in function name (sellectCurrency())
  • Added BouncingScrollPhysics() to selectCurrency()

theperu
theperu approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@theperu theperu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll keep it here for a couple of days and then we'll merge 😁

@mikev-cw
Copy link
Collaborator

Good to me too. Nice catch!

@theperu theperu merged commit 51914e9 into RIP-Comm:main Jan 23, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theperu theperu theperu approved these changes

@mikev-cw mikev-cw mikev-cw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jackrua @mikev-cw @theperu