Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated accounts and categories management #85

Merged
merged 2 commits into from
May 4, 2023

Conversation

lucaantonelli
Copy link
Collaborator

@lucaantonelli lucaantonelli commented Apr 28, 2023

  • Added logo
  • The splash screen now should be entirely visible and not cropped by a white circle (it is an android 12 and newer behaviour, so it looks a bit small on the latest android versions)
  • Added accounts and categories management (insert/update/delete) with new styling
  • Improved homepage
  • Settings page with new layout

Known Issues:

  • If you delete the main account or deselect it, it throws an error because as of now, the main account is mandatory. We should decide if it can stay as is, maybe automatically setting the main account as the most used (in last year or something like that).

Added icon for android and ios
. Added accounts and categories management (insert/update/delete) with new styling
. Improved homepage
. Settings page with new layout
@theperu
Copy link
Collaborator

theperu commented Apr 29, 2023

Great job! I tried the app a little bit and noticed a few things:

  • For some reason the app icon is a bit weird when you look all the backgrounded apps

Screenshot 2023-04-29 at 12 58 00

- I am able to submit a transfer without the second account selected, when I comeback to the home then I see an error in the last transactions section.
Transfer.error.mov
  • This is not related to your PR but is something that I noticed. Although I can create new transactions the values for the accounts don't get updated.
  • The categories for income and expenses should be separated (ex. this means that when I am submitting a new expense I shouldn't see "income")

@GBergatto
Copy link
Contributor

I noticed that color is an integers used as the index for a list of default colors. Wouldn't it be better to save the HEX code instead and convert it directly to the Color class? With the current solution, if we were to edit the list of colors, we'd have to change all indexes across the database.

This was linked to issues May 4, 2023
@mikev-cw
Copy link
Collaborator

mikev-cw commented May 4, 2023

Super cool! I'm merging this. As discussed on Discord, we will take care of issues raised by @theperu and @GBergatto on other PRs.

@mikev-cw mikev-cw merged commit d986a8f into RIP-Comm:main May 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up app icon New Transaction Page
4 participants