Merge pull request #108 from RIPAGlobal/feature/v1-sync-main

Reduce diff between 'v1' and 'main'

app/models/scimitar/resources/base.rb

@@ -129,7 +129,7 @@ def constantize_complex_types(hash)
 
           if scim_attribute && scim_attribute.complexType
             if scim_attribute.multiValued
-              self.send("#{attr_name}=", attr_value.map {|attr_for_each_item| complex_type_from_hash(scim_attribute, attr_for_each_item)})
+              self.send("#{attr_name}=", attr_value&.map {|attr_for_each_item| complex_type_from_hash(scim_attribute, attr_for_each_item)})
             else
               self.send("#{attr_name}=", complex_type_from_hash(scim_attribute, attr_value))
             end

spec/models/scimitar/resources/base_spec.rb

@@ -27,6 +27,14 @@ def self.scim_attributes
     end
 
     context '#initialize' do
+      it 'accepts nil for non-required attributes' do
+        resource = CustomResourse.new(name: nil, names: nil, privateName: nil)
+
+        expect(resource.name).to be_nil
+        expect(resource.names).to be_nil
+        expect(resource.privateName).to be_nil
+      end
+
       shared_examples 'an initializer' do | force_upper_case: |
         it 'which builds the nested type' do
           attributes = {

spec/requests/active_record_backed_resources_controller_spec.rb

@@ -511,6 +511,7 @@
         expect(response.headers['Content-Type']).to eql('application/scim+json; charset=utf-8')
 
         result = JSON.parse(response.body)
+
         expect(result['scimType']).to eql('invalidValue')
         expect(result['detail']).to include('is reserved')
       end
@@ -530,7 +531,6 @@
         #
         expect_any_instance_of(MockUsersController).to receive(:replace).once.and_call_original
         expect_any_instance_of(MockUsersController).to receive(:save! ).once.and_call_original
-
         expect {
           put "/Users/#{@u2.primary_key}", params: attributes.merge(format: :scim)
         }.to_not change { MockUser.count }