Ignore meta on create #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds in the required files to run tasks like rspec and db:migrate.
If a meta attribute is passed in on create or update instead of being ignored it is set as an attribute on the resource, the as_json function then fails to parse this because it is a hash instead of an object.
|
That's a nice fix. Thanks! |
|
Version 2.0.1 incorporating your fix is now available via RubyGems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running into an issue while setting up Azure AD, as meta was being sent as a hash and not a Meta object, we added a simple check and also added bin so that setting up pg and running rspec and other tasks is easier.