Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the primary attribute to the Address schema #18

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Adds the primary attribute to the Address schema #18

merged 1 commit into from
Jul 13, 2022

Conversation

pelted
Copy link
Contributor

@pelted pelted commented Jun 3, 2022

What this does:
Adds a primary boolean attribute to Schema::Address. There is a note in the Specification versus implementation section regarding the the use of primary in several complex types on a User.

Why?
Okta sends a primary attribute with the addresses list. This resolves the resulting unknown attribute error.

@pond pond merged commit a44ecbd into RIPAGlobal:main Jul 13, 2022
@pond
Copy link
Member

pond commented Jul 13, 2022

Thanks for the PR. Sorry it took a while to merge - I just didn't see a notification back in June for these.

@pond pond added enhancement New feature or request bug Something isn't working labels Jul 13, 2022
@pond
Copy link
Member

pond commented Jul 14, 2022

(Oh - by the way - if you could please check bundle exec rspec for future PRs and just make sure that tests still pass, fixing things up if necessary, that'd be handy - thanks!).

@pond
Copy link
Member

pond commented Jul 14, 2022

Available now in v2.1 (https://rubygems.org/gems/scimitar).

@pelted
Copy link
Contributor Author

pelted commented Jul 14, 2022

(Oh - by the way - if you could please check bundle exec rspec for future PRs and just make sure that tests still pass, fixing things up if necessary, that'd be handy - thanks!).

Oh man, sorry.. Was so focused on our tests that by the time I got the PR up that didn't even cross my mind. Thank you for getting these in.

@pond
Copy link
Member

pond commented Jul 14, 2022

Oh man, sorry.. Was so focused on our tests that by the time I got the PR up that didn't even cross my mind. Thank you for getting these in.

No worries; it's always nice to have additional tests and/or ensure that tests work, but when a feature makes sense and helps improve the base software, I'd never reject a PR for that alone. Many thanks for the contribution 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants