Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds configuration option to not require value attributes. #19

Merged
merged 2 commits into from
Jul 13, 2022
Merged

Adds configuration option to not require value attributes. #19

merged 2 commits into from
Jul 13, 2022

Conversation

pelted
Copy link
Contributor

@pelted pelted commented Jun 3, 2022

What this does:
Provides a Engine configuration option to require (or not) the value filed for complex vdtp types.

Why?
Some providers are sending NULL values when syncing lists such as phone numbers. Although I agree with the Readme statement:

there's no point being sent (say) an e-mail section which has entries that don't provide the e-mail address!

Unfortunately, if an identity provider is sending NULL rather than omitting the result from a list this provides a way to work around that. We should be using Model validations anyway.

@pond
Copy link
Member

pond commented Jul 13, 2022

I'll have a think about this one - maybe a cleaner fix is to allow those spec-optional things to be optional in the schema, and rely on the gem integrator's model validations underneath as suggested. Otherwise it makes all VDTP types optional which seems a bit broad.

@pond
Copy link
Member

pond commented Jul 13, 2022

Yeah, OK, so fair enough. I see from your description that you're concerned about more than one possible type receiving null in the optional field, so I'll merge this and add a bit of documentation around it too.

This will be in v2.1.0 hopefully released later today (NZ time).

@pond pond merged commit 11df1d6 into RIPAGlobal:main Jul 13, 2022
@pond
Copy link
Member

pond commented Jul 14, 2022

Available now in v2.1 (https://rubygems.org/gems/scimitar).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants