Handle CONTENT_TYPE header containing charset correctly #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. This is definitely an omission/bug in Scimitar. I note from https://www.rubydoc.info/github/rack/rack/Rack%2FRequest%2FHelpers:media_type that we should probably be using |
Flixt
force-pushed
the
support-content-type-with-charset
branch
from
2518551
to
483e0f2
Compare
|
Good catch, |
pond
approved these changes
Mar 20, 2023
|
That's great, thanks! I'll release that as 2.4.2 shortly. |
This was referenced Mar 20, 2023
Merged
Closed
|
This is now released: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered a problem using Microsoft Azure AD and traced it down to Microsoft sending
application/scim+json; charset=utf-8in theCONTENT_TYPEheader when callingPOST /Users.Since the CONTENT_TYPE header can contain more than just the Mime-Type scimitar should use
start_with?instead of==. This PR changes that.PS: I'm not sure if stripping the charset away from the
CONTENT_TPYEheader is wise. I just added that because the tests looked "more correct" to me first sight. If you know more or have objections just drop me a line.