Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring late packets and fixing qbuf references #58

Merged
merged 4 commits into from
Nov 18, 2015

Conversation

danielquinn
Copy link
Collaborator

This is sort of a loaded PR because there was a mixup in merging the "late" packets issue. I thought that was already in master, but I guess not :-(

Anyway, there's 3 things in here of note:

  • Traceroutes can sometimes have "late" packets which, currently should be considered bogus. In future, that's going to change though and this code will have to be firmware version away and perform shuffling for later versions. For now though, we just ignore these packets.
  • Issue qbuf issue #56, a failure to capture qbuf data is fixed here too. Basically the problem was that some DNS results are a single result, while others are result-sets, and the qbuf is placed in totally different places in each case. We now account for this.
  • A documentation update. Better formatting, and importing of the newly-renamed CHANGES.rst and newly-minted CONTRIBUTING.rst into the wider docs.

Closes #56.

Jterbeest added a commit that referenced this pull request Nov 18, 2015
Ignoring late packets and fixing qbuf references
@Jterbeest Jterbeest merged commit 901b005 into RIPE-NCC:master Nov 18, 2015
.. _changes: https://github.com/RIPE-NCC/ripe.atlas.sagan/blob/master/CHANGES.rst
.. _mailing list: https://www.ripe.net/mailman/listinfo/ripe-atlas
.. _GitHub Issue Queue: https://github.com/RIPE-NCC/ripe.atlas.sagan/issues
.. _messenger pigeon: https://tools.ietf.org/html/rfc1149
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if we can have only on contrib file for the 3 projects since they can be basically the same. Is there a way to have it in one of them and them have a link for the other projects.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same thinking, but I don't know. I believe there's something in Sphinx about "inter-sphinx" documentation, and rtfd also has some sort of method to allow interlinking, but I have no experience with it.

Maybe create this as an issue and one of us can look into it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qbuf issue
3 participants