Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cover a case where rtt_average does not exist #91

Merged
merged 4 commits into from
May 27, 2021
Merged

cover a case where rtt_average does not exist #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
15fa3e1
cover a case where rtt_average does not exist
Sep 6, 2019
c57a51a
Merge branch 'master' of https://github.com/RIPE-NCC/ripe.atlas.sagan
Sep 6, 2019
7b28a8f
drop py34, add py37
Sep 6, 2019
2d3dc1e
update travis.yml for py37
Sep 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
language: python
python:
- "2.7"
- "3.4"
- "3.5"
- "3.6"
- "3.7"
install:
- pip install .
- pip install nose
Expand Down
2 changes: 1 addition & 1 deletion ripe/atlas/sagan/ping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def __init__(self, data, **kwargs):
self.rtt_median = None # Redefined in self._set_rtt_median()
self.packets = []

if self.rtt_average < 0:
if self.rtt_average is None or self.rtt_average < 0:
self.rtt_average = self.rtt_min = self.rtt_max = None

if 0 < self.firmware < 4460:
Expand Down
6 changes: 2 additions & 4 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,9 @@
"Operating System :: Unix",
"Programming Language :: Python",
"Programming Language :: Python :: 2.7",
"Programming Language :: Python :: 3.1",
"Programming Language :: Python :: 3.2",
"Programming Language :: Python :: 3.3",
"Programming Language :: Python :: 3.4",
"Programming Language :: Python :: 3.5",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Topic :: Internet :: WWW/HTTP",
],
)
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tox]
envlist=py27,py34,py35,py36
envlist=py27,py35,py36,py37

[testenv]
commands=python setup.py test []
Expand Down