Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure document sending is disabled by default #158

Closed
Tjzabel opened this issue Aug 12, 2019 · 2 comments
Closed

Make sure document sending is disabled by default #158

Tjzabel opened this issue Aug 12, 2019 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Anyone is welcome to help us with this! needs testing Needs testing or QA before closing

Comments

@Tjzabel
Copy link
Member

Tjzabel commented Aug 12, 2019

Through a quick conversation on #ritlug-teleirc, someone mentioned their API key was being sent through when sending over a document.

This feature was turned off by default, so I would like to double check to make sure this is actually working as intended. Document sending should only be done in channels where the owners feel it is okay for their key to be seen.

Steps to close this issue

  1. Do a fresh clone of teleIRC
  2. cp env.example .env
  3. Update channel info in .env
  4. Run teleIRC
  5. Send over a document from Telegram
  6. Make sure document does not make it over the bridge
@Tjzabel Tjzabel added bug Something isn't working priority:med labels Aug 12, 2019
@Tjzabel Tjzabel added this to Backlog in TeleIRC development via automation Aug 12, 2019
@jwflory jwflory added good first issue Good for newcomers help wanted Anyone is welcome to help us with this! needs testing Needs testing or QA before closing and removed priority:med labels Sep 2, 2019
@jwflory
Copy link
Member

jwflory commented Sep 2, 2019

The option is disabled in the example configuration file:

IRC_SEND_DOCUMENT=false

I don't have a record of this conversation. Did we ask the person to check what version of TeleIRC they were running? Without more data or someone willing to confirm this, I suggest closing this as invalid. I think it is more likely they were running an outdated version of TeleIRC.

@Tjzabel
Copy link
Member Author

Tjzabel commented Sep 2, 2019

At this point, I am okay with closing this issue as invalid.

@Tjzabel Tjzabel closed this as completed Sep 2, 2019
TeleIRC development automation moved this from Backlog to Done Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Anyone is welcome to help us with this! needs testing Needs testing or QA before closing
Projects
Development

No branches or pull requests

2 participants