Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merging from master #1

Merged
merged 8 commits into from
Mar 18, 2021
Merged

merging from master #1

merged 8 commits into from
Mar 18, 2021

Conversation

RK-GCP
Copy link
Owner

@RK-GCP RK-GCP commented Mar 18, 2021

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integration systems such as TravisCI.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

thinkerou and others added 8 commits January 10, 2021 23:51
@thinkerou
Revert "Adding ppc64le architecture support on travis-ci (#2538)" (#2602
a28cc08 
)
@laojianzi @thinkerou
test: fixed the TestUnixSocket test on windows (#2595)
4d2dad5 
Co-authored-by: thinkerou <thinkerou@gmail.com>
@codenoid @thinkerou
gin mode unknown: show available mode (#2567)
e753c50 
Co-authored-by: thinkerou <thinkerou@gmail.com>
@0x2d3c @thinkerou
fix error gin support min Go version (#2584)
f4bc259 
Co-authored-by: thinkerou <thinkerou@gmail.com>
@teutonicjoe @thinkerou
Fixes to the graceful shutdown example (#2552)
46ddd42 
* Change error comparison to use errors.Is() and add a line of whitespace before the if statement on graceful shutdown

* Change from log.Fatalf to log.Printf to ensure the graceful shutdown actually works

Co-authored-by: J. J. Bigorra <josep@prowarehouse.nl>
Co-authored-by: thinkerou <thinkerou@gmail.com>
@Snawoot @thinkerou
basic auth: fix timing oracle (#2609)
b01605b 
Co-authored-by: thinkerou <thinkerou@gmail.com>
@sashamelentyev
chore: Deleted spaces (#2622)
e899771
@panjf2000 @thinkerou
Remove the tedious named return value (#2620)
1bdf86b 
Co-authored-by: thinkerou <thinkerou@gmail.com>
@RK-GCP RK-GCP merged commit 5723314 into RK-GCP:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
9 participants
@RK-GCP @thinkerou @laojianzi @codenoid @0x2d3c @teutonicjoe @Snawoot @sashamelentyev @panjf2000