New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing users to set their launcher preferences (steam vs epic). #123
Conversation
I noticed that the preference isn't used by the showroom and more importantly story mode, so we might have to tell people to start a regular match before jumping straight into story mode. But you could argue that the preference chooser isn't present in the story mode UI, so they won't notice it anyway. |
Great point, I didn't consider that! Maybe I'll give it a separate form and pull from persisted settings when starting showroom and story mode matches. |
Wow nice, approved |
It might be better to rename the last option to "use epic games login tricks" or something similar to show that it only affects epic games (if thats the case ofcourse) |
Co-authored-by: Darxeal <jira.pihrt@volny.cz>
One more thing, the navbar button makes more sense in the story mode navbar (but it can be in the main navbar too). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Story mode changes look good to me
Determines whether we try to launch with Steam or Epic. If Epic, gives the user the option to use our fancy login technique that launches, kills and re-launches the game in rapid succession. User is given a warning that this may look strange.
The default value for everybody is Epic. That's OK even for users who only have Steam, because the system behavior in that case is to try Epic first, then fall back to Steam if it fails.
Setting will be remembered the next time you open the GUI.